Add non-streaming response to approximate prefix cache. #1719
+882
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-rebase
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zetxqx
force-pushed
the
prefix-cache-resp
branch
from
e21b3fe to
565a1ce
Compare
zetxqx
force-pushed
the
prefix-cache-resp
branch
2 times, most recently
from
a7ddc30 to
7476ad3
Compare
k8s-ci-robot
added
size/XL
zetxqx
force-pushed
the
prefix-cache-resp
branch
3 times, most recently
from
e1f9e73 to
eec941c
Compare
Contributor
Author
|
/assign @liu-cong |
k8s-ci-robot
added
the
needs-rebase
zetxqx
force-pushed
the
prefix-cache-resp
branch
from
eec941c to
824af68
Compare
k8s-ci-robot
removed
the
needs-rebase
…ethod of Messages in ChatCompletions.
zetxqx
force-pushed
the
prefix-cache-resp
branch
from
824af68 to
39ae663
Compare
kfswain
reviewed
Nov 17, 2025
| // MarshalMessagesToJSON converts a slice of Message structs into a JSON byte slice. | ||
| // This is used to create a consistent byte representation for prefix caching calculations, | ||
| // allowing us to identify common prefixes between LLM requests and responses. | ||
| func MarshalMessagesToJSON(messages ...Message) ([]byte, error) { |
Collaborator
There was a problem hiding this comment.
nit: I think this belongs in the llmresponse.go file, or potentially out of the types package altogether
Collaborator
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add non streaming response to prefix cache, several points to pay attention:
requestcontrolplugin into 3 separate plugins to add streamed request functionality #1661ResponseCompleteto accept a*types.LLMResponsewhich has richer structure.ChatCompletionsmessages for prefix caching is now standardized viaMarshalMessagesToJSONto improve caching accuracy for multi-turn conversations.Which issue(s) this PR fixes:
Fixes Partially #971
Does this PR introduce a user-facing change?: